On Wed, Oct 03, 2018 at 11:18:26AM +0200, Daniel Vetter wrote:
It's for legacy drivers only (atomic ones should use drm_atomic_helper_check_plane_state() instead), and there's no users left except the one in the primary plane helpers.
Signed-off-by: Daniel Vetter daniel.vetter@intel.com
Reviewed-by: Ville Syrjälä ville.syrjala@linux.intel.com
drivers/gpu/drm/drm_plane_helper.c | 49 +++++++----------------------- include/drm/drm_plane_helper.h | 11 ------- 2 files changed, 11 insertions(+), 49 deletions(-)
diff --git a/drivers/gpu/drm/drm_plane_helper.c b/drivers/gpu/drm/drm_plane_helper.c index 965286231600..33b3e6892787 100644 --- a/drivers/gpu/drm/drm_plane_helper.c +++ b/drivers/gpu/drm/drm_plane_helper.c @@ -100,43 +100,17 @@ static int get_connectors_for_crtc(struct drm_crtc *crtc, return count; }
-/**
- drm_plane_helper_check_update() - Check plane update for validity
- @plane: plane object to update
- @crtc: owning CRTC of owning plane
- @fb: framebuffer to flip onto plane
- @src: source coordinates in 16.16 fixed point
- @dst: integer destination coordinates
- @rotation: plane rotation
- @min_scale: minimum @src:@dest scaling factor in 16.16 fixed point
- @max_scale: maximum @src:@dest scaling factor in 16.16 fixed point
- @can_position: is it legal to position the plane such that it
doesn't cover the entire crtc? This will generally
only be false for primary planes.
- @can_update_disabled: can the plane be updated while the crtc
is disabled?
- @visible: output parameter indicating whether plane is still visible after
clipping
- Checks that a desired plane update is valid. Drivers that provide
- their own plane handling rather than helper-provided implementations may
- still wish to call this function to avoid duplication of error checking
- code.
- RETURNS:
- Zero if update appears valid, error code on failure
- */
-int drm_plane_helper_check_update(struct drm_plane *plane,
struct drm_crtc *crtc,struct drm_framebuffer *fb,struct drm_rect *src,struct drm_rect *dst,unsigned int rotation,int min_scale,int max_scale,bool can_position,bool can_update_disabled,bool *visible)+static int drm_plane_helper_check_update(struct drm_plane *plane,
struct drm_crtc *crtc,struct drm_framebuffer *fb,struct drm_rect *src,struct drm_rect *dst,unsigned int rotation,int min_scale,int max_scale,bool can_position,bool can_update_disabled,bool *visible){ struct drm_plane_state plane_state = { .plane = plane, @@ -173,7 +147,6 @@ int drm_plane_helper_check_update(struct drm_plane *plane,
return 0; } -EXPORT_SYMBOL(drm_plane_helper_check_update);
/**
- drm_primary_helper_update() - Helper for primary plane update
diff --git a/include/drm/drm_plane_helper.h b/include/drm/drm_plane_helper.h index 1999781781c7..7bff930b8b10 100644 --- a/include/drm/drm_plane_helper.h +++ b/include/drm/drm_plane_helper.h @@ -38,17 +38,6 @@ */ #define DRM_PLANE_HELPER_NO_SCALING (1<<16)
-int drm_plane_helper_check_update(struct drm_plane *plane,
struct drm_crtc *crtc,struct drm_framebuffer *fb,struct drm_rect *src,struct drm_rect *dest,unsigned int rotation,int min_scale,int max_scale,bool can_position,bool can_update_disabled,bool *visible);int drm_primary_helper_update(struct drm_plane *plane, struct drm_crtc *crtc, struct drm_framebuffer *fb, -- 2.19.0.rc2
Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx