Hi Mamta,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master] [also build test WARNING on v5.0-rc8 next-20190301] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Mamta-Shukla/drm-vkms-Add-overlay-p... config: i386-randconfig-x006-201909 (attached as .config) compiler: gcc-8 (Debian 8.2.0-20) 8.2.0 reproduce: # save the attached .config to linux build tree make ARCH=i386
All warnings (new ones prefixed by >>):
drivers/gpu/drm/vkms/vkms_plane.c: In function 'vkms_overlay_init':
drivers/gpu/drm/vkms/vkms_plane.c:182:10: warning: returning 'int' from a function with return type 'struct drm_plane *' makes pointer from integer without a cast [-Wint-conversion]
return -ENOMEM; ^
vim +182 drivers/gpu/drm/vkms/vkms_plane.c
169 170 struct drm_plane *vkms_overlay_init(struct vkms_device *vkmsdev) 171 { 172 struct drm_device *dev = &vkmsdev->drm; 173 const struct drm_plane_helper_funcs *funcs; 174 struct drm_plane *overlay; 175 const u32 *formats; 176 int ret, nformats; 177 unsigned int blend_caps = BIT(DRM_MODE_BLEND_PIXEL_NONE) | 178 BIT(DRM_MODE_BLEND_PREMULTI); 179 180 overlay = kzalloc(sizeof(*overlay), GFP_KERNEL); 181 if (!overlay)
182 return -ENOMEM;
183 184 formats = vkms_overlay_formats; 185 nformats = ARRAY_SIZE(vkms_overlay_formats); 186 funcs = &vkms_primary_helper_funcs; 187 drm_plane_helper_add(overlay, funcs); 188 drm_plane_create_alpha_property(overlay); 189 drm_plane_create_blend_mode_property(overlay, blend_caps); 190 191 ret = drm_universal_plane_init(dev, overlay, 0, 192 &vkms_plane_funcs, 193 formats, nformats, 194 NULL, 195 DRM_PLANE_TYPE_OVERLAY, NULL); 196 if (ret){ 197 kfree(overlay); 198 return ERR_PTR(ret); 199 } 200 201 return overlay; 202 } 203
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation