On Thu, Sep 19, 2013 at 05:40:34PM +0100, Damien Lespiau wrote:
Now that we ask to adjust the crtc timings for stereo modes, the correct pipe_src_w and pipe_src_h can be found in crtc_vdisplay and crtc_hdisplay.
Signed-off-by: Damien Lespiau damien.lespiau@intel.com
drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 0573036..69d7167 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -8425,9 +8425,6 @@ intel_modeset_pipe_config(struct drm_crtc *crtc, drm_mode_copy(&pipe_config->adjusted_mode, mode); drm_mode_copy(&pipe_config->requested_mode, mode);
- pipe_config->pipe_src_w = mode->hdisplay;
- pipe_config->pipe_src_h = mode->vdisplay;
- pipe_config->cpu_transcoder = (enum transcoder) to_intel_crtc(crtc)->pipe; pipe_config->shared_dpll = DPLL_ID_PRIVATE;
@@ -8462,6 +8459,9 @@ encoder_retry: /* Fill in default crtc timings, allow encoders to overwrite them. */ drm_mode_set_crtcinfo(&pipe_config->adjusted_mode, CRTC_STEREO_DOUBLE);
I think a oneline comment here to explain the ordering would be nice. -Daniel
- pipe_config->pipe_src_w = pipe_config->adjusted_mode.crtc_hdisplay;
- pipe_config->pipe_src_h = pipe_config->adjusted_mode.crtc_vdisplay;
- /* Pass our mode to the connectors and the CRTC to give them a chance to
- adjust it according to limitations or connector properties, and also
- a chance to reject the mode entirely.
-- 1.8.3.1
Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx