2 May
2022
2 May
'22
11:49 a.m.
On Fri, 29 Apr 2022, "Murthy, Arun R" arun.r.murthy@intel.com wrote:
+static int output_bpc_show(struct seq_file *m, void *data) {
Can we have a meaningful name instead of 'm' ? Upon changing this parameter name, you can have my Reviewed-By: Arun R Murthy arun.r.murthy@intel.com
Please keep 'm'. It's by far the most common name for struct seq_file * in the kernel:
$ git grep -o "struct seq_file *[a-zA-Z0-9_]+" | sed 's/^.*:struct seq_file *//' | sort | uniq -c | sort -rn | head -5 2212 m 1219 seq 1126 s 135 sf 121 file
BR, Jani.
--
Jani Nikula, Intel Open Source Graphics Center