Re: [PATCH 3/3] drm/msm/dp: remove max_pclk_khz field from dp_panel/dp_display

Quoting Dmitry Baryshkov (2022-03-23 03:35:46)

Since the last commit, the max_pclk_khz became constant, it's set to DP_MAX_PIXEL_CLK_KHZ and never changed afterwards. Remove it completely and use DP_MAX_PIXEL_CLK_KHZ directly.

Signed-off-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org

Reviewed-by: Stephen Boyd swboyd@chromium.org

diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c index af5f1b001192..a94c9b34f397 100644 --- a/drivers/gpu/drm/msm/dp/dp_drm.c +++ b/drivers/gpu/drm/msm/dp/dp_drm.c @@ -88,9 +88,7 @@ static enum drm_mode_status dp_connector_mode_valid(

    dp_disp = to_dp_connector(connector)->dp_display;

•   if ((dp_disp->max_pclk_khz <= 0) ||
  

•                   (dp_disp->max_pclk_khz > DP_MAX_PIXEL_CLK_KHZ) ||
  

•                   (mode->clock > dp_disp->max_pclk_khz))
  

•   if (mode->clock > DP_MAX_PIXEL_CLK_KHZ)
            return MODE_BAD;
  

Can we have a followup patch to return MODE_CLOCK_HIGH?