Re: [PATCH v17 4/7] fbmon: add videomode helpers

Hi!

On Fri, Feb 01, 2013 at 06:29:50PM +0900, Jingoo Han wrote:

On Friday, January 25, 2013 6:02 PM, Steffen Trumtrar wrote

...

• fbmode->sync = 0;
• fbmode->vmode = 0;
• if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH)

• fbmode->sync |= FB_SYNC_HOR_HIGH_ACT;
  

• if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH)

Um, it seems to be a type. 'H'SYNC -> 'V'SYNC Thus, it would be changed as below:

VESA_DMT_HSYNC_HIGH -> VESA_DMT_VSYNC_HIGH

Damn. You are right, that is a typo. But I guess some maintainer (Dave) really, really wants to take the series now and this can wait for an -rc. No?! ;-)

Thanks, Steffen

...

• fbmode->sync |= FB_SYNC_VERT_HIGH_ACT;
  

• if (vm->data_flags & DISPLAY_FLAGS_INTERLACED)

• fbmode->vmode |= FB_VMODE_INTERLACED;
  

• if (vm->data_flags & DISPLAY_FLAGS_DOUBLESCAN)

• fbmode->vmode |= FB_VMODE_DOUBLE;
  

• fbmode->flag = 0;