As we propagate the error back to our caller, who may act intelligently upon that error, we should refrain from shouting out that there has been an *ERROR* prematurely.
Signed-off-by: Chris Wilson chris@chris-wilson.co.uk --- drivers/gpu/drm/drm_gem.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index 24efae4..88c6662 100644 --- a/drivers/gpu/drm/drm_gem.c +++ b/drivers/gpu/drm/drm_gem.c @@ -357,7 +357,6 @@ drm_gem_create_mmap_offset(struct drm_gem_object *obj) obj->size / PAGE_SIZE, 0, false);
if (!list->file_offset_node) { - DRM_ERROR("failed to allocate offset for bo %d\n", obj->name); ret = -ENOSPC; goto out_free_list; } @@ -371,10 +370,8 @@ drm_gem_create_mmap_offset(struct drm_gem_object *obj)
list->hash.key = list->file_offset_node->start; ret = drm_ht_insert_item(&mm->offset_hash, &list->hash); - if (ret) { - DRM_ERROR("failed to add to map hash\n"); + if (ret) goto out_free_mm; - }
return 0;