Re: [PATCH] drm/tegra: Stop using iommu_present()

On 4/5/22 17:19, Robin Murphy wrote:

Remove the pointless check. host1x_drm_wants_iommu() cannot return true unless an IOMMU exists for the host1x platform device, which at the moment means the iommu_present() test could never fail.

Signed-off-by: Robin Murphy robin.murphy@arm.com

drivers/gpu/drm/tegra/drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index 9464f522e257..bc4321561400 100644 --- a/drivers/gpu/drm/tegra/drm.c +++ b/drivers/gpu/drm/tegra/drm.c @@ -1149,7 +1149,7 @@ static int host1x_drm_probe(struct host1x_device *dev) goto put; }

• if (host1x_drm_wants_iommu(dev) && iommu_present(&platform_bus_type)) {

• if (host1x_drm_wants_iommu(dev)) { tegra->domain = iommu_domain_alloc(&platform_bus_type); if (!tegra->domain) { err = -ENOMEM;

host1x_drm_wants_iommu() returns true if there is no IOMMU for the host1x platform device of Tegra20/30 SoCs.