Re: [PATCH v6 1/2] habanalabs: define uAPI to export FD for DMA-BUF

On Tue, Sep 28, 2021 at 8:13 PM Jason Gunthorpe jgg@ziepe.ca wrote:

On Sun, Sep 12, 2021 at 07:53:08PM +0300, Oded Gabbay wrote:

...

  /* HL_MEM_OP_* */
  __u32 op;

• /* HL_MEM_* flags */
  

• /* HL_MEM_* flags.
  

•  * For the HL_MEM_OP_EXPORT_DMABUF_FD opcode, this field holds the
  

•  * DMA-BUF file/FD flags.
  

•  */
  __u32 flags;
  /* Context ID - Currently not in use */
  __u32 ctx_id;
  

@@ -1072,6 +1091,13 @@ struct hl_mem_out {

                  __u32 pad;
          };

•         /* Returned in HL_MEM_OP_EXPORT_DMABUF_FD. Represents the
  

•          * DMA-BUF object that was created to describe a memory
  

•          * allocation on the device's memory space. The FD should be
  

•          * passed to the importer driver
  

•          */
  

•         __u64 fd;
  

fd's should be a s32 type in a fixed width uapi.

Yep, will correct this.

I usually expect to see the uapi changes inside the commit that consumes them, splitting the patch like this seems strange but harmless.

I'll remember that when I send the RDMA patches down the road :)

Thanks, Oded

Jason