Hi Andy,
On Tue, Mar 15, 2022 at 2:33 PM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
On Tue, Mar 15, 2022 at 12:07:03PM +0100, Geert Uytterhoeven wrote:
There is no "reversed" handling in drm_fb_xrgb8888_to_mono_reversed(): the function just converts from color to grayscale, and reduces the number of grayscale levels from 256 to 2 (i.e. brightness 0-127 is mapped to 0, 128-255 to 1). All "reversed" handling is done in the repaper driver, where this function originated.
Hence make this clear by renaming drm_fb_xrgb8888_to_mono_reversed() to drm_fb_xrgb8888_to_mono(), and documenting the black/white pixel mapping.
W/ or w/o the below remark being addressed Reviewed-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
Thanks!
--- a/drivers/gpu/drm/drm_format_helper.c +++ b/drivers/gpu/drm/drm_format_helper.c @@ -692,12 +692,12 @@ void drm_fb_xrgb8888_to_mono_reversed(void *dst, unsigned int dst_pitch, const v for (y = 0; y < lines; y++) { src32 = memcpy(src32, vaddr, len_src32); drm_fb_xrgb8888_to_gray8_line(gray8, src32, linepixels);
drm_fb_gray8_to_mono_reversed_line(mono, gray8, dst_pitch,start_offset, end_len);
drm_fb_gray8_to_mono_line(mono, gray8, dst_pitch, start_offset,end_len);Can be one line now (definition is already quite behind 80 limit).
Yeah, but the code isn't. Nevertheless, this will be shortened in a later patch.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds