Hi Marek,
Thank you for the patch.
On Sun, Jun 12, 2022 at 03:21:50PM +0200, Marek Vasut wrote:
Mark empty implementations of drm_of_get_data_lanes_count and drm_of_get_data_lanes_ep as static inline, just like the rest of empty implementations of various functions in drm_of.h . Add missing comma to drm_of_get_data_lanes_count_ep() .
Fixes: fc801750b197 ("drm: of: Add drm_of_get_data_lanes_count and drm_of_get_data_lanes_ep") Reported-by: kernel test robot lkp@intel.com Signed-off-by: Marek Vasut marex@denx.de Cc: Andrzej Hajda andrzej.hajda@intel.com Cc: Laurent Pinchart laurent.pinchart@ideasonboard.com Cc: Lucas Stach l.stach@pengutronix.de Cc: Maxime Ripard maxime@cerno.tech Cc: Robert Foss robert.foss@linaro.org Cc: Sam Ravnborg sam@ravnborg.org To: dri-devel@lists.freedesktop.org
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
include/drm/drm_of.h | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/include/drm/drm_of.h b/include/drm/drm_of.h index 92387eabcb6f0..10ab58c407467 100644 --- a/include/drm/drm_of.h +++ b/include/drm/drm_of.h @@ -112,16 +112,18 @@ drm_of_lvds_get_data_mapping(const struct device_node *port) return -EINVAL; }
-int drm_of_get_data_lanes_count(const struct device_node *endpoint,
const unsigned int min, const unsigned int max)+static inline int +drm_of_get_data_lanes_count(const struct device_node *endpoint,
const unsigned int min, const unsigned int max)
Unrelated to this patch, do we need "const" for the unsigned int arguments ?
{ return -EINVAL; }
-int drm_of_get_data_lanes_count_ep(const struct device_node *port,
int port_reg, int regconst unsigned int min,const unsigned int max)+static inline int +drm_of_get_data_lanes_count_ep(const struct device_node *port,
int port_reg, int reg,const unsigned int min,const unsigned int max){ return -EINVAL; }