Dne ponedeljek, 31. maj 2021 ob 19:24:40 CEST je Jernej Škrabec napisal(a):
Hi!
Dne petek, 28. maj 2021 ob 22:30:35 CEST je Roman Stratiienko napisal(a):
Create callback to allow updating engine's registers on mode change.
Signed-off-by: Roman Stratiienko r.stratiienko@gmail.com Reviewed-by: Jernej Skrabec jernej.skrabec@siol.net
BTW, update my R-B tag with gmail address and fix issues pointed out by Plaes and me in order to use it.
drivers/gpu/drm/sun4i/sun4i_crtc.c | 3 +++ drivers/gpu/drm/sun4i/sunxi_engine.h | 12 ++++++++++++ 2 files changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/sun4i/sun4i_crtc.c b/drivers/gpu/drm/sun4i/
sun4i_crtc.c
index 45d9eb552d86..8f01a6b2bbef 100644 --- a/drivers/gpu/drm/sun4i/sun4i_crtc.c +++ b/drivers/gpu/drm/sun4i/sun4i_crtc.c @@ -146,6 +146,9 @@ static void sun4i_crtc_mode_set_nofb(struct drm_crtc
*crtc)
struct sun4i_crtc *scrtc = drm_crtc_to_sun4i_crtc(crtc);
sun4i_tcon_mode_set(scrtc->tcon, encoder, mode);
- if (scrtc->engine->ops->mode_set)
scrtc->engine->ops->mode_set(scrtc->engine, mode);}
static const struct drm_crtc_helper_funcs sun4i_crtc_helper_funcs = { diff --git a/drivers/gpu/drm/sun4i/sunxi_engine.h b/drivers/gpu/drm/sun4i/
sunxi_engine.h
index 548710a936d5..7faa844646ff 100644 --- a/drivers/gpu/drm/sun4i/sunxi_engine.h +++ b/drivers/gpu/drm/sun4i/sunxi_engine.h @@ -9,6 +9,7 @@ struct drm_plane; struct drm_device; struct drm_crtc_state; +struct drm_display_mode;
struct sunxi_engine;
@@ -108,6 +109,17 @@ struct sunxi_engine_ops { * This function is optional. */ void (*vblank_quirk)(struct sunxi_engine *engine);
- /**
* @mode_set:** This callback is used to update engine registers that* responsible for display frame size and other mode attributes.** This function is optional.*/- void (*mode_set)(struct sunxi_engine *engine,
struct drm_display_mode *mode);Mark mode as const.
Best regards, Jernej
};
/**