On Tue, 2011-01-04 at 19:21 -0500, Alex Deucher wrote:
On Mon, Jan 3, 2011 at 8:49 AM, Tejun Heo tj@kernel.org wrote:
With cmwq, there's no reason for radeon to use a dedicated workqueue. Drop dev_priv->wq and use system_wq instead.
Because radeon_driver_irq_uninstall_kms() may be called from unsleepable context, the work items can't be flushed from there. Instead, init and flush from radeon_irq_kms_init/fini().
While at it, simplify canceling/flushing of rdev->pm.dynpm_idle_work. Always initialize and sync cancel instead of being unnecessarily smart about it.
Signed-off-by: Tejun Heo tj@kernel.org Cc: David Airlie airlied@linux.ie Cc: dri-devel@lists.freedesktop.org
Only compile tested. Please feel free to take it into the subsystem tree or simply ack - I'll route it through the wq tree.
Patch looks good to me. I'm not sure what's the best way to send this upstream. I'm working on some irq changes in the same area now, so I'd prefer if we pushed it through Dave's tree, but I can handle it either way.
I'll pull it into my tree for merging to Linus.
Dave.
Acked-by: Alex Deucher alexdeucher@gmail.com