Hi Sandy.
Thanks for taking care of this, but...
On Mon, Sep 23, 2019 at 08:51:45PM +0800, Sandy Huang wrote:
cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp.
Signed-off-by: Sandy Huang hjc@rock-chips.com
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c index 89f5a75..ab7d423 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c @@ -644,7 +644,7 @@ static int atmel_hlcdc_plane_atomic_check(struct drm_plane *p, int xdiv = i ? fb->format->hsub : 1; int ydiv = i ? fb->format->vsub : 1;
state->bpp[i] = fb->format->cpp[i];
state->bpp[i] = fb->format->bpp[i] / 8;
Awaiting conclusion on Daniels comment on PATCH 1 and has dropped this patch for now. And please address the concerns Rob has about bisectability in your cover letter for v2.
Sam