Hi,
First of all, thanks a lot for all your patch. And thanks Emil for your feedback.
I have a suggestion here:
Emil: Could you give me your Acked-by or maybe Reviewed-by for the writeback series? With that, I can finally apply the series.
Sidong: Secondly, after applying the writeback series, I would suggest you to understand Emil's comments (he already provides the link) and prepare a new patch based on that. Before you submit your patch, I recommend you to test it with https://patchwork.freedesktop.org/series/68352/ and kms_flip.
How about that?
Best Regards
On 05/31, Emil Velikov wrote:
On Sun, 31 May 2020 at 14:12, Sidong Yang realwakka@gmail.com wrote:
Optimize looping pixels in compute_crc() and blend(). Calculate src_offset in start of looping horizontally and increase it. It's better than calculating in every pixels.
When you say "optimize" have you observed any actual benefits of the patch - be that smaller binary, faster execution time, etc? If there are - mentioned them in the commit message. Otherwise, it doesn't optimise anything.
A while back, I've suggested something similar [1] mostly for cosmetic purposes - doubt there's much benefits beyond that.
HTH -Emil [1] https://patchwork.freedesktop.org/patch/365177/#comment_674314