Hi Tomasz, Please find the inline comments. Will post the next version today.
Thanks. Leela Krishna Amudala. ------- Original Message ------- Sender : Tomasz Figat.figa@samsung.com Junior Software Engineer/SPRC-Linux Platform (SSD)/Samsung Electronics Date : Sep 05, 2012 13:22 (GMT+05:30) Title : Re: [PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd
Hi Leela,
See my comments inline.
On Thursday 16 of August 2012 12:08:08 Leela Krishna Amudala wrote:
+enum fimd_version_type {
- VERSION_8, /* FIMD_VERSION8 */
+};
+struct drm_fimd_driver_data {
- enum fimd_version_type fimd_ver;
+};
+struct drm_fimd_driver_data exynos5_drm_fimd_driver_data = {
- .fimd_ver = VERSION_8,
+};
I think that the approach with timing_base, as suggested by Joonyoung Shim, would be much cleaner.
Leela: Okay, will go with timing_base approach only
+static struct platform_device_id exynos_drm_fimd_driver_ids[] = {
- {
- .name = "exynos4-fb",
- }, {
- .name = "exynos5-drm-fimd",
- .driver_data = (unsigned long)&exynos5_drm_fimd_driver_data,
- },
- {},
+}; +MODULE_DEVICE_TABLE(platform, exynos_drm_fimd_driver_ids);
If I see correctly, this will crash on a null pointer dereference on Exynos4 without DT, because of NULL driver_data.
Leela: yes, you are right, will take care of this
P.S. I think you should CC linux-arm-kernel and linux-samsung-soc lists when submitting patches related to ARM and Samsung SoCs.
Leela: Okay, will do it next time.
Best regards,