On Fri, Feb 4, 2011 at 11:11 AM, Linus Torvalds torvalds@linux-foundation.org wrote:
On Thu, Feb 3, 2011 at 5:05 PM, Keith Packard keithp@keithp.com wrote:
The goal is to make it so that when you *do* set a mode, DPMS gets set to ON (as the monitor will actually be "on" at that point). Here's a patch which does the DPMS_ON precisely when setting a mode.
Ok, patch looks sane, but it does leave me with the "what about the 'fb_changed' case?" question. Is that case basically guaranteed to not change any existing dpms state?
Yes its inconsistent behaviour but nothing in the fb_changed case will affect the DPMS state. I expect we should probably do that so all paths via that function turn DPMS on, and it'll be consistent, might be something for 39.
Dave.