Re: [PATCH] drm/sun4i: add missing put_device() call in sun8i_r40_tcon_tv_set_mux()

On 2020/08/25 21:38, Maxime Ripard wrote:

Hi,

On Tue, Aug 25, 2020 at 07:44:03PM +0800, Yu Kuai wrote:

...

If sun8i_r40_tcon_tv_set_mux() succeed, at_dma_xlate() doesn't have a corresponding put_device(). Thus add put_device() to fix the exception handling for this function implementation.

Fixes: 0305189afb32 ("drm/sun4i: tcon: Add support for R40 TCON") Signed-off-by: Yu Kuai yukuai3@huawei.com

That doesn't sound right, we're not using at_dma_xlate at all in that driver?

Hi!

sry about that, should be sun8i_r40_tcon_tv_set_mux(), same as the title said.

Best regards, Yu Kuai