On -10.01.-28163 20:59, alexdeucher@gmail.com wrote: [SNIP]
#define RADEON_CHUNK_ID_RELOCS 0x01 #define RADEON_CHUNK_ID_IB 0x02 #define RADEON_CHUNK_ID_FLAGS 0x03
/* The first dword of RADEON_CHUNK_ID_FLAGS is a uint32 of these flags: */ #define RADEON_CS_KEEP_TILING_FLAGS 0x01 +#define RADEON_CS_USE_VM 0x02 +/* The second dword of RADEON_CHUNK_ID_FLAGS is a uint32 that sets the ring type */ +#define RADEON_CS_RING_GFX 0 +#define RADEON_CS_RING_COMPUTE 1 +/* The third dword of RADEON_CHUNK_ID_FLAGS is a sint32 that sets the priority */ +/* 0 = normal, + = higher priority, - = lower priority */ +struct drm_radeon_cs_ring_priority {
- int32_t priority;
+};
Sorry, missed that one before, the "struct drm_radeon_cs_ring_priority" is pretty much pointless.
My comment was going more into that direction: struct drm_radeon_cs_flags { uint32_t flags; uint32_t ring_type; int32_t priority; };
Anyway, the patch is finally committed, but I think we should fix (remove?) that before it goes further upstream.
Christian.