On 22 February 2016 at 12:48, Emil Velikov emil.l.velikov@gmail.com wrote:
[Cutting down the CC list]
Hi there,
Must admit that looking at contributors from chromium.org feels quite heart warming.
On 19 February 2016 at 00:50, C Stout cstout@chromium.org wrote:
Change-Id: I6c891515d93a6f1a597e762090c3530a6810c6c6
drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 43 +++++++++++++++++++++++++----- drivers/gpu/drm/msm/adreno/adreno_device.c | 8 ++++++ drivers/gpu/drm/msm/adreno/adreno_gpu.c | 3 ++- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 ++++ 4 files changed, 52 insertions(+), 7 deletions(-)
Please include your fill name and a signed-off-by as mentioned in the documentation [1]. Without those the maintainer/Rob C cannot pick your work.
While you're there you can nuke the Change-id tag - they're normally frowned upon by kernel developers although Rob might be ok keeping them. Please add a line or two of commit message. Some examples/ideas
- what are the differences wrt the 420 devices and/or how you noticed
them (official documentation, reverse engineering). what's missing to get the devices fully working, how it's been tested, etc.
Completely forgot: prefix the patches based on the subsystem used. Otherwise it's more likely that the maintainer email filter will miss them. Thinking about "drm/msm: add support for adreno 430" although git log is your friend.
Regards, Emil