Quoting Vinod Polimera (2022-02-21 06:51:24)
diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c index b32295a..5c7dc82 100644 --- a/drivers/gpu/drm/bridge/panel.c +++ b/drivers/gpu/drm/bridge/panel.c @@ -102,30 +136,82 @@ static void panel_bridge_detach(struct drm_bridge *bridge) drm_connector_cleanup(connector); }
-static void panel_bridge_pre_enable(struct drm_bridge *bridge) +static void panel_bridge_pre_enable(struct drm_bridge *bridge,
struct drm_bridge_state *old_bridge_state){ struct panel_bridge *panel_bridge = drm_bridge_to_panel_bridge(bridge);
struct drm_atomic_state *old_state = old_bridge_state->base.state;struct drm_encoder *encoder = bridge->encoder;struct drm_crtc *crtc;struct drm_crtc_state *old_crtc_state;crtc = bridge_drm_get_new_connector_crtc(encoder, old_state);if (!crtc)return;old_crtc_state = drm_atomic_get_old_crtc_state(old_state, crtc);if (old_crtc_state && old_crtc_state->self_refresh_active)
Can you please add some comment about why self_refresh_active means we should bail out from this function? Such a comment would be helpful to understand the code quickly vs. having to figure out what the intention of the logic is. The analogix driver has
/* Don't touch the panel if we're coming back from PSR */
so even mentioning PSR here would be helpful.