Hi Jim,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on linux/master tegra-drm/drm/tegra/for-next drm-tip/drm-tip linus/master v5.9-rc2 next-20200826] [cannot apply to drm/drm-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jim-Cromie/dyndbg-POC-use-dynamic_d... base: git://anongit.freedesktop.org/drm-intel for-linux-next config: x86_64-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All errors (new ones prefixed by >>):
drivers/gpu/drm/i915/i915_params.c: In function 'param_set_dyndbg':
drivers/gpu/drm/i915/i915_params.c:307:11: error: implicit declaration of function 'dynamic_debug_exec_queries' [-Werror=implicit-function-declaration]
307 | chgct = dynamic_debug_exec_queries(query, "i915"); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors
# https://github.com/0day-ci/linux/commit/1b9bcd2cceed427d96bc9bf4eae6619201d6... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jim-Cromie/dyndbg-POC-use-dynamic_debug_exec_queries-in-DRM/20200827-010409 git checkout 1b9bcd2cceed427d96bc9bf4eae6619201d645d6 vim +/dynamic_debug_exec_queries +307 drivers/gpu/drm/i915/i915_params.c
283 284 static int param_set_dyndbg(const char *instr, const struct kernel_param *kp) 285 { 286 static unsigned long int old_val; 287 unsigned int val; 288 unsigned long int changes, result; 289 int rc, chgct = 0, totct = 0, bitpos; 290 char query[OUR_QUERY_SIZE]; 291 292 rc = kstrtouint(instr, 0, &val); 293 if (rc) { 294 pr_err("set_dyndbg: failed\n"); 295 return -EINVAL; 296 } 297 result = val; 298 pr_info("set_dyndbg: result:0x%lx from %s\n", result, instr); 299 300 changes = result ^ old_val; 301 302 for_each_set_bit(bitpos, &changes, NUM_CLASSES) { 303 304 sprintf(query, "format='^%s' %cp", pr_debug_classes[bitpos], 305 test_bit(bitpos, &result) ? '+' : '-'); 306
307 chgct = dynamic_debug_exec_queries(query, "i915");
308 totct += chgct; 309 pr_info("change ct:%d on format='%s'\n", chgct, 310 pr_debug_classes[bitpos]); 311 } 312 old_val = result; 313 pr_info("change ct:%d\n", totct); 314 return 0; 315 } 316 static int param_get_dyndbg(char *buffer, const struct kernel_param *kp) 317 { 318 return scnprintf(buffer, PAGE_SIZE, "%u\n", 319 *((unsigned int *)kp->arg)); 320 } 321 static const struct kernel_param_ops param_ops_dyndbg = { 322 .set = param_set_dyndbg, 323 .get = param_get_dyndbg, 324 }; 325
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org