Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver

Hi Lee,

On Wed, 15 Aug 2018 06:24:35 +0100 Lee Jones lee.jones@linaro.org wrote:

...

+static const struct mfd_cell lcdc_cells[] = {

• {

• .name = "atmel-lcdc-pwm",
  

• .of_compatible = "atmel,lcdc-pwm",
  

• },
• {

• .name = "atmel-lcdc-dc",
  

• .of_compatible = "atmel,lcdc-display-controller",
  

• },

+};

Will you be adding any more devices, or is this the entirety of the device? If the latter, I suggest that this doesn't warrant being an MFD.

Is there a lower limit to define when an MFD is recommended, or is it that you find a PWM (driving a backlight) and a display controller close enough to be implemented in a single driver?

I personally prefer the separation we have today, because I can then place the drivers where they belong (PWM subsystem and DRM subsystem) and the respective maintainers know about these drivers.

Regards,

Boris