On Thu, Nov 11, 2021 at 11:49 AM yunfei.dong@mediatek.com yunfei.dong@mediatek.com wrote:
Hi Tzung-Bi,
Thanks for your suggestion. On Wed, 2021-11-10 at 18:30 +0800, Tzung-Bi Shih wrote:
On Tue, Nov 09, 2021 at 08:50:17PM +0800, Yunfei Dong wrote:
Manage each hardware information which includes irq/power/clk. The hardware includes LAT0, LAT1 and CORE.
The commit message doesn't explain the code. Could you provide some explanations about how the async mechanism works? (e.g. A bitmap for all sub-devices' readiness ...)
add more detail description for commit message.
Reported-by: kernel test robot lkp@intel.com
Apparently wrong tag.
Remove
diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c index b7a51e96d4ba..eb2af42aa102 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c @@ -18,19 +18,49 @@
#include "mtk_vcodec_drv.h" #include "mtk_vcodec_dec.h" +#include "mtk_vcodec_dec_hw.h" #include "mtk_vcodec_dec_pm.h" #include "mtk_vcodec_intr.h" -#include "mtk_vcodec_util.h"
Why does mtk_vcodec_util.h need to remove?
Put #include "mtk_vcodec_util.h" in mtk_vcodec_dec_hw.h.
If this file directly uses anything from that header file, it should include it directly, instead of depending on some transitive inclusion.
This would avoid having to deal with breakage if/when the includes from header files change beneath you.
ChenYu