Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

19 Aug 2020


      ...
...
...
+++ b/drivers/video/backlight/sky81452-backlight.c
@@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
   				num_entry);
   	if (ret < 0) {
   		dev_err(dev, "led-sources node is invalid.\n");

	of_node_put(np);
return ERR_PTR(-EINVAL);

}

I propose to add the jump target “put_node” so that a bit of common exception
handling code can be better reused at the end of this function implementation.
…
...
You can safely ignore any review comments from Markus!
How does this feedback fit to the Linux coding style?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docu...
Regards,
Markus

    