On Mon, 27 Jan 2020 18:26:52 +0100 Daniel Vetter daniel@ffwll.ch wrote:
On Mon, Jan 27, 2020 at 12:00:32PM +0100, Boris Brezillon wrote:
One of the last remaining objects to not have its atomic state.
This is being motivated by our attempt to support runtime bus-format negotiation between elements of the bridge chain. This patch just paves the road for such a feature by adding a new drm_bridge_state object inheriting from drm_private_obj so we can re-use some of the existing state initialization/tracking logic.
Signed-off-by: Boris Brezillon boris.brezillon@collabora.com Signed-off-by: Neil Armstrong narmstrong@baylibre.com Reviewed-by: Neil Armstrong narmstrong@baylibre.com Acked-by: Daniel Vetter daniel.vetter@ffwll.ch
Changes in v9:
- Clarify the fact that the bridge->atomic_reset() and {connector,plane,crtc,...}->reset() semantics are different
- Move the drm_atomic_private_obj_init() call back to drm_bridge_attach()
- Check the presence of ->atomic_duplicate_state instead of ->atomic_reset in drm_atomic_add_encoder_bridges()
- Fix copy&paste errors in the atomic bridge state helpers doc
- Add A-b/R-b tags
Changes in v8:
- Move bridge state helpers out of the CONFIG_DEBUGFS section
Changes in v7:
- Move helpers, struct-defs, ... to atomic helper files to avoid the drm -> drm_kms_helper -> drm circular dep
- Stop providing default implementation for atomic state reset, duplicate and destroy hooks (has to do with the helper/core split)
- Drop all R-b/T-b as helpers have now be moved to other places
^^ we generally keep the changelog when committing in drm, since it contains useful stuff.
Alright (I tend to forget that drm does things differently). I find it a bit redundant given the final commit also contains a patchwork link which contains all revisions + the discussion that happened on each version.
If you don't want to do that, then at least update the commit message to make sure all the design discussion is reflected in there somewhere. Which atm it definitely isn't.
I'll update the commit messages to add those changelogs.