Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used

On Mon, 14 Jun 2010 19:12:31 PDT, "Justin P. Mattock" said:

what I tried was this:

if (!rc) printk("test........"\n")

and everything looked good, but as a soon as I changed

rc = transmit_cmd(chip,&tpm_cmd, TPM_INTERNAL_RESULT_SIZE, "attempting to determine the timeouts");

to this:

rc = transmit_cmd(chip,&tpm_cmd, TPM_INTERNAL_RESULT_SIZE);

if (!rc) printk("attempting to determine the timeouts\n");

*baffled* Why did you think that would work? transmit_cmd()s signature has 4 parameters.