Re: [PATCH 03/27] drm/arc: Actually bother with handling atomic events.

Op 08-06-16 om 14:18 schreef Daniel Vetter:

The drm core has a nice ready-made helper for exactly the simple case where it should fire on the next vblank.

Note that arming the vblank event in _begin is probably too early, and might easily result in the vblank firing too early, before the new set of planes are actually disabled. But that's kinda a minor issue compared to just outright hanging userspace.

v2: Be more robust and either arm, when the CRTC is on, or just send the event out right away.

Cc: Carlos Palminha palminha@synopsys.com Cc: Alexey Brodkin abrodkin@synopsys.com Cc: linux-snps-arc@lists.infradead.org Signed-off-by: Daniel Vetter daniel.vetter@intel.com

Wouldn't it be better to do this in atomic_flush then?