Re: [PATCH 1/2] drm: support for rotated scanout

On Tue, Sep 04, 2012 at 11:35:56AM -0500, Rob Clark wrote:

From: Rob Clark rob@ti.com

For drivers that can support rotated scanout, the extra parameter checking in drm-core, while nice, tends to get confused. To solve this drivers can set the crtc or plane invert_dimensions field so that the dimension checking takes into account the rotation that the driver is performing.

v1: original v2: remove invert_dimensions from plane, at Ville's suggestion. Userspace can give rotated src coordinates, so invert_dimensions is not required for planes.

Signed-off-by: Rob Clark rob@ti.com

Sorry for the delay Rob, I somehow missed this. In any case, the patch looks OK to me.

Reviewed-by: Ville Syrjälä ville.syrjala@linux.intel.com