On Wed, Sep 07, 2016 at 07:51:48PM +0200, Rask Ingemann Lambertsen wrote:
On Wed, Aug 31, 2016 at 4:18 PM, Maxime Ripard maxime.ripard@free-electrons.com wrote:
From: Mylène Josserand mylene.josserand@free-electrons.com
The GR8 is an SoC made by Nextthing loosely based on the sun5i family.
Since it's not clear yet what we can factor out and merge with the A10s and A13 support, let's keep it out of the sun5i.dtsi include tree. We will figure out what can be shared when things settle down.
Signed-off-by: Mylène Josserand mylene.josserand@free-electrons.com Signed-off-by: Maxime Ripard maxime.ripard@free-electrons.com
arch/arm/boot/dts/gr8.dtsi | 1080 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 1080 insertions(+) create mode 100644 arch/arm/boot/dts/gr8.dtsi
diff --git a/arch/arm/boot/dts/gr8.dtsi b/arch/arm/boot/dts/gr8.dtsi new file mode 100644 index 000000000000..d21cfa3f3c14 --- /dev/null +++ b/arch/arm/boot/dts/gr8.dtsi
In the node names, you sometimes use underscores and sometimes use hyphens. Here are the ones I spotted:
osc3M: osc3M_clk {pll3x2: pll3x2_clk {pll7x2: pll7x2_clk {display-engine {sram-controller@01c00000 {otg_sram: sram-section@0000 {dma: dma-controller@01c02000 {tve0: tv-encoder@01c0a000 {tcon0: lcd-controller@01c0c000 {intc: interrupt-controller@01c20400 {lcd_rgb666_pins: lcd_rgb666@0 {nand_pins_a: nand_base0@0 {nand_cs0_pins_a: nand_cs@0 {nand_rb0_pins_a: nand_rb@0 {uart1_cts_rts_pins_a: uart1-cts-rts@0 {fe0: display-frontend@01e00000 {be0: display-backend@01e60000 {Underscores should not be used in node names. [1][2] Since you're adding a new file here, please use hyphens instead.
I wonder what the rationale behind this is. The ePAPR clearly documents the underscore as being a valid character for the node names.
I'll change the few inconsistencies though.
Thanks! Maxime