On Wed, Apr 20, 2016 at 08:58:44PM +0200, Luis R. Rodriguez wrote:
On Wed, Apr 20, 2016 at 07:42:13PM +0100, Chris Wilson wrote:
The ioremap() hidden behind the io_mapping_map_wc() convenience helper can be used for remapping multiple pages. Extend the helper so that future callers can use it for larger ranges.
Signed-off-by: Chris Wilson chris@chris-wilson.co.uk Cc: Tvrtko Ursulin tvrtko.ursulin@intel.com Cc: Daniel Vetter daniel.vetter@intel.com Cc: Jani Nikula jani.nikula@linux.intel.com Cc: David Airlie airlied@linux.ie Cc: Yishai Hadas yishaih@mellanox.com Cc: Dan Williams dan.j.williams@intel.com Cc: Ingo Molnar mingo@kernel.org Cc: "Peter Zijlstra (Intel)" peterz@infradead.org Cc: David Hildenbrand dahi@linux.vnet.ibm.com Cc: Luis R. Rodriguez mcgrof@kernel.org Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: netdev@vger.kernel.org Cc: linux-rdma@vger.kernel.org Cc: linux-kernel@vger.kernel.org
We have 2 callers today, in the future, can you envision this API getting more options? If so, in order to avoid the pain of collateral evolutions I can suggest a descriptor being passed with the required settings / options. This lets you evolve the API without needing to go in and modify old users. If you choose not to that's fine too, just figured I'd chime in with that as I've seen the pain with other APIs, and I'm putting an end to the needless set of collateral evolutions this way.
Do you have a good example in mind? I've one more patch to try and take advantage of the io-mapping (that may or not be such a good idea in practice) but I may as well see if I can make io_mapping more useful when I do. -Chris