On Fri 2018-11-16 00:06:45, Sebastian Reichel wrote:
This adds the required infrastructure for manually updated displays, such as DSI command mode panels. While those panels often support partial updates we currently always do a full refresh.
The display will be refreshed when something calls the dirty callback, such as libdrm's drmModeDirtyFB(). This is currently being done at least by the kernel console and Xorg (with modesetting driver) in their default configuration. Weston does not implement this and the fbdev backend does not work (display will not update). Weston's DRM backend uses double buffering and the page flip will trigger a display refresh and seems to work as expected.
Signed-off-by: Sebastian Reichel sebastian.reichel@collabora.com
Acked-by: Pavel Machek pavel@ucw.cz
@@ -708,6 +802,18 @@ struct drm_crtc *omap_crtc_init(struct drm_device *dev, omap_crtc->channel = channel; omap_crtc->name = channel_names[channel];
- /* We want to refresh manually updated displays from dirty callback,
Nit: Comment style does not match coding style.
/* *
--- a/drivers/gpu/drm/omapdrm/omap_fb.c
+++ b/drivers/gpu/drm/omapdrm/omap_fb.c @@ -66,8 +66,49 @@ struct omap_framebuffer { struct mutex lock; };
+/* iterate thru all the crts, returning ones that are attached to the same fb */
Start with big letter -- "Iterate"?
Thanks, Pavel