On Wed, Aug 17, 2011 at 5:18 PM, Thomas Reim reimth@gmail.com wrote:
Dear Alex,
I try to get the information from Chris.
Were would you add the quirk? Currently we collect all these floating chip realisations in the "requires extended DDC probing" function. But this function just sets the related flag. If we go for a connector specific quirk we would need to separate this laptop from the others, wouldn't we?
There are already a number of systems with connector quirks. See radeon_atom_apply_quirks() in radeon_atombios.c.
And if I remember correctly, the ECS board had also two versions: one with HDMI connector and one without. The latter had the floating bus, but IDs were the same.
Right, usually the HDMI port was sold as a PCIE card and a lot of vendors sold the same board both with and without the hdmi card.
Alex
Best regards
Thomas
Am Mittwoch, den 17.08.2011, 11:08 -0400 schrieb Alex Deucher:
On Wed, Aug 17, 2011 at 5:03 AM, Thomas Reim reimth@googlemail.com wrote:
Toshiba Satellite L300D with ATI Mobility Radeon X1100 sends data to i2c bus for a HDMI connector that is not implemented/existent on the notebook's board.
If the laptop doesn't actually have the port, it would be better to just add a connector table quirk to just remove it. However, the HDMI port may be on a docking station.
Alex
Fix by applying extented DDC probing for this connector.
Requires [PATCH] drm/radeon: Extended DDC Probing for Connectors with Improperly Wired DDC Lines
Tested for kernel 2.6.38 on Toshiba Satellite L300D notebook
BugLink: http://bugs.launchpad.net/bugs/826677
Signed-off-by: Thomas Reim reimth@gmail.com Acked-by: Chris Routh routhy@gmail.com Cc: stable@kernel.org
drivers/gpu/drm/radeon/radeon_connectors.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c index 6d6b5f1..ef5a6f0 100644 --- a/drivers/gpu/drm/radeon/radeon_connectors.c +++ b/drivers/gpu/drm/radeon/radeon_connectors.c @@ -464,6 +464,16 @@ static bool radeon_connector_needs_extended_probe(struct radeon_device *dev, (supported_device == ATOM_DEVICE_DFP2_SUPPORT)) return true; }
- /* TOSHIBA Satellite L300D with ATI Mobility Radeon x1100
- * (RS690M) sends data to i2c bus for a HDMI connector that
- * is not implemented */
- if ((dev->pdev->device == 0x791f) &&
- (dev->pdev->subsystem_vendor == 0x1179) &&
- (dev->pdev->subsystem_device == 0xff68)) {
- if ((connector_type == DRM_MODE_CONNECTOR_HDMIA) &&
- (supported_device == ATOM_DEVICE_DFP2_SUPPORT))
- return true;
- }
/* Default: no EDID header probe required for DDC probing */ return false; -- 1.7.1