Hi,
On Tue, May 10, 2022 at 12:30 PM Douglas Anderson dianders@chromium.org wrote:
While working on the DP AUX bus code I found a few small things that should be fixed. Namely the non-devm version of of_dp_aux_populate_ep_devices() was missing an export. There was also an extra blank line in a kerneldoc and a kerneldoc that incorrectly documented a return value. Fix these.
Fixes: aeb33699fc2c ("drm: Introduce the DP AUX bus") Signed-off-by: Douglas Anderson dianders@chromium.org
None of these seem critical, so my plan is to land this in drm-misc-next and not drm-misc-fixes. This will avoid merge conflicts with future patches.
Changes in v3:
- Patch ("drm/dp: Export symbol / kerneldoc fixes...") split for v3.
drivers/gpu/drm/display/drm_dp_aux_bus.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
I landed this one in drm-misc-next:
39c28cdfb719 drm/dp: Export symbol / kerneldoc fixes for DP AUX bus
I chose "drm-misc-next" instead of a "fixes" branch because: * It's not super urgent. * I'm still hoping to get review for the other patches in this series and it would be nice to avoid the conflicts when landing.
-Doug
diff --git a/drivers/gpu/drm/display/drm_dp_aux_bus.c b/drivers/gpu/drm/display/drm_dp_aux_bus.c index dccf3e2ea323..552f949cff59 100644 --- a/drivers/gpu/drm/display/drm_dp_aux_bus.c +++ b/drivers/gpu/drm/display/drm_dp_aux_bus.c @@ -66,7 +66,6 @@ static int dp_aux_ep_probe(struct device *dev)
- @dev: The device to remove.
- Calls through to the endpoint driver remove.
*/
static void dp_aux_ep_remove(struct device *dev) { @@ -120,8 +119,6 @@ ATTRIBUTE_GROUPS(dp_aux_ep_dev); /**
- dp_aux_ep_dev_release() - Free memory for the dp_aux_ep device
- @dev: The device to free.
*/
- Return: 0 if no error or negative error code.
static void dp_aux_ep_dev_release(struct device *dev) { @@ -256,6 +253,7 @@ int of_dp_aux_populate_ep_devices(struct drm_dp_aux *aux)
return 0;} +EXPORT_SYMBOL_GPL(of_dp_aux_populate_ep_devices);
static void of_dp_aux_depopulate_ep_devices_void(void *data) { -- 2.36.0.550.gb090851708-goog