Re: [RFC PATCH v3 1/4] drm: Introduce generic probe function for component based masters.

On Mon, Nov 09, 2015 at 11:57:27AM +0000, Liviu Dudau wrote:

Meanwhile, what is your suggestion regarding the patchset. I've seen David has sent Linus a pull request for 4.4-rc1 that includes it. Should we send a revert for rockchip commit and then patch later the function?

It definitely needs to be fixed, and I'd suggest its early enough in the -rc cycle (which hasn't begun yet) to simply fix drm_of_component_probe() to take two compare functions.

I'd also suggest at this point another change: please rename it to drm_of_kms_component_probe() since this is only a generic case for KMS drivers. GPU DRM drivers need something different.