-----Original Message----- From: Alexandru-Cosmin Gheorghe [mailto:Alexandru- Cosmin.Gheorghe@arm.com] Sent: Thursday, June 14, 2018 6:21 PM To: Shankar, Uma uma.shankar@intel.com Cc: dcastagna@chromium.org; intel-gfx@lists.freedesktop.org; emil.l.velikov@gmail.com; dri-devel@lists.freedesktop.org; Syrjala, Ville ville.syrjala@intel.com; nd@arm.com; Lankhorst, Maarten maarten.lankhorst@intel.com Subject: Re: [RFC v3 0/8] Add Plane Color Properties
On Tue, Jun 12, 2018 at 04:01:31AM +0000, Shankar, Uma wrote:
-----Original Message----- From: dri-devel [mailto:dri-devel-bounces@lists.freedesktop.org] On Behalf Of Alexandru-Cosmin Gheorghe Sent: Monday, June 11, 2018 3:47 PM To: Shankar, Uma uma.shankar@intel.com Cc: dcastagna@chromium.org; intel-gfx@lists.freedesktop.org; emil.l.velikov@gmail.com; dri-devel@lists.freedesktop.org; Syrjala, Ville ville.syrjala@intel.com; nd@arm.com; Lankhorst, Maarten maarten.lankhorst@intel.com Subject: Re: [RFC v3 0/8] Add Plane Color Properties
Hi Uma,
Any progress on userspace for this? I was thinking on working on using this in drm_hwcomposer.
Hi Alex, Not much work has been done till now on user space side. You can go ahead and try to enable it in drm_hwcomposer.
Hi,
I'm missing the hardware/driver that can do all three operations DEGAMMA, CSC, GAMMA for now, any chance you have a setup env with drm_hwcomposer and you would have time to help me with some testing after I would be writing the code ?
I can help with testing this out in some of our intel platforms. Will implement the platform hooks for the same.
Let me know once you have the hwc changes ready.
Regards, Uma Shankar
Thank you, Alex Gheorghe
On Fri, Mar 09, 2018 at 11:47:41PM +0530, Uma Shankar wrote:
This patch series adds properties for plane color features. It adds properties for degamma used to linearize data, CSC used for gamut conversion, and gamma used to again non-linearize data as per panel supported color space. These can be utilize by user space to convert planes from one format to another, one color space to another etc.
Usersapce can take smart blending decisions and utilize these hardware supported plane color features to get accurate color profile. The same can help in consistent color quality from source to panel taking advantage of advanced color features in hardware.
These patches just add the property interfaces and enable helper functions.
This series adds Intel Gen9 specific plane gamma feature. We can build up and add other platform/hardware specific implementation on top of this series
Note: This is just to get a design feedback whether these interfaces look ok. Based on community feedback on interfaces, we will implement IGT tests to validate plane color features. This is un-tested
currently.
Also, userspace implementation to use these properties is currently not available.
v2: Dropped legacy gamma table for plane as suggested by Maarten. Added Gen9/BDW plane gamma feature and rebase on tot.
v3: Added a new drm_color_lut_ext structure to accommodate 32 bit precision entries, pointed to by Brian, Starkey for HDR usecases. Addressed Sean,Paul comments and moved plane color properties to drm_plane instead of mode_config. Added property documentation as
suggested by Daniel, Vetter.
Fixed a rebase fumble which occurred in v2, pointed by Emil Velikov.
Uma Shankar (8): drm: Add Enhanced Gamma LUT precision structure drm: Add Plane Degamma properties drm: Add Plane CTM property drm: Add Plane Gamma properties drm: Define helper function for plane color enabling drm/i915: Enable plane color features drm/i915: Implement Plane Gamma for Bdw and Gen9 platforms drm/i915: Load plane color luts from atomic flip
Documentation/gpu/drm-kms.rst | 18 ++++ drivers/gpu/drm/drm_atomic.c | 30 +++++++ drivers/gpu/drm/drm_atomic_helper.c | 12 +++ drivers/gpu/drm/drm_plane.c | 131
++++++++++++++++++++++++++++++
drivers/gpu/drm/i915/i915_drv.h | 5 ++ drivers/gpu/drm/i915/i915_pci.c | 5 +- drivers/gpu/drm/i915/i915_reg.h | 24 ++++++ drivers/gpu/drm/i915/intel_atomic_plane.c | 4 + drivers/gpu/drm/i915/intel_color.c | 80 ++++++++++++++++++ drivers/gpu/drm/i915/intel_device_info.h | 5 ++ drivers/gpu/drm/i915/intel_display.c | 4 + drivers/gpu/drm/i915/intel_drv.h | 10 +++ drivers/gpu/drm/i915/intel_sprite.c | 4 + include/drm/drm_color_mgmt.h | 5 ++ include/drm/drm_plane.h | 66 +++++++++++++++ include/uapi/drm/drm_mode.h | 15 ++++ 16 files changed, 417 insertions(+), 1 deletion(-) -- 1.9.1
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
-- Cheers, Alex G