Hi Tomi,
Thank you for the patch.
On Tue, Nov 24, 2020 at 02:45:32PM +0200, Tomi Valkeinen wrote:
We can drop dsi_display_disable() which just calls _dsi_display_disable(), and rename _dsi_display_disable() to dsi_display_disable().
Same comment as for the previous patch. I'd actually squash the two.
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
Signed-off-by: Tomi Valkeinen tomi.valkeinen@ti.com
drivers/gpu/drm/omapdrm/dss/dsi.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index e50418db71ef..d23fc43f1d1e 100644 --- a/drivers/gpu/drm/omapdrm/dss/dsi.c +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c @@ -63,8 +63,6 @@ static int dsi_vc_send_null(struct dsi_data *dsi, int vc, int channel); static ssize_t _omap_dsi_host_transfer(struct dsi_data *dsi, int vc, const struct mipi_dsi_msg *msg);
-static void dsi_display_disable(struct omap_dss_device *dssdev);
#ifdef DSI_PERF_MEASURE static bool dsi_perf; module_param(dsi_perf, bool, 0644); @@ -3767,7 +3765,7 @@ static void dsi_display_enable(struct dsi_data *dsi) DSSDBG("dsi_display_ulps_enable FAILED\n"); }
-static void _dsi_display_disable(struct dsi_data *dsi, +static void dsi_display_disable(struct dsi_data *dsi, bool disconnect_lanes, bool enter_ulps) { WARN_ON(!dsi_bus_is_locked(dsi)); @@ -3786,17 +3784,6 @@ static void _dsi_display_disable(struct dsi_data *dsi, mutex_unlock(&dsi->lock); }
-static void dsi_display_disable(struct omap_dss_device *dssdev) -{
- struct dsi_data *dsi = to_dsi_data(dssdev);
- WARN_ON(!dsi_bus_is_locked(dsi));
- DSSDBG("dsi_display_disable\n");
- _dsi_display_disable(dsi, true, false);
-}
static int dsi_enable_te(struct dsi_data *dsi, bool enable) { dsi->te_enabled = enable; @@ -3820,7 +3807,7 @@ static void omap_dsi_ulps_work_callback(struct work_struct *work)
dsi_enable_te(dsi, false);
- _dsi_display_disable(dsi, false, true);
dsi_display_disable(dsi, false, true);
dsi_bus_unlock(dsi);
} @@ -4954,7 +4941,7 @@ static void dsi_bridge_disable(struct drm_bridge *bridge)
dsi_disable_video_output(dssdev, VC_VIDEO);
- dsi_display_disable(dssdev);
dsi_display_disable(dsi, true, false);
dsi_bus_unlock(dsi);
}