Hi, Hsin-Yi:
Hsin-Yi Wang hsinyi@chromium.org 於 2021年1月29日 週五 下午5:23寫道：
From: Yongqiang Niu yongqiang.niu@mediatek.com
Not all SoC has dither function in gamma module. Add private data to control this function setting.
Applied to mediatek-drm-next [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?...
Regards, Chun-Kuang.
Signed-off-by: Yongqiang Niu yongqiang.niu@mediatek.com Signed-off-by: Hsin-Yi Wang hsinyi@chromium.org Reviewed-by: CK Hu ck.hu@mediatek.com
drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c index 6b520807921e3..5092a27ccc28b 100644 --- a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c +++ b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c @@ -27,7 +27,7 @@ #define LUT_10BIT_MASK 0x03ff
struct mtk_disp_gamma_data {
u32 reserved;
bool has_dither;};
/** @@ -93,8 +93,9 @@ void mtk_gamma_config(struct device *dev, unsigned int w,
mtk_ddp_write(cmdq_pkt, h << 16 | w, &gamma->cmdq_reg, gamma->regs, DISP_GAMMA_SIZE);
mtk_dither_set_common(gamma->regs, &gamma->cmdq_reg, bpc, DISP_GAMMA_CFG,GAMMA_DITHERING, cmdq_pkt);
if (gamma->data && gamma->data->has_dither)mtk_dither_set_common(gamma->regs, &gamma->cmdq_reg, bpc,DISP_GAMMA_CFG, GAMMA_DITHERING, cmdq_pkt);}
void mtk_gamma_start(struct device *dev) @@ -174,8 +175,13 @@ static int mtk_disp_gamma_remove(struct platform_device *pdev) return 0; }
+static const struct mtk_disp_gamma_data mt8173_gamma_driver_data = {
.has_dither = true,+};
static const struct of_device_id mtk_disp_gamma_driver_dt_match[] = {
{ .compatible = "mediatek,mt8173-disp-gamma"},
{ .compatible = "mediatek,mt8173-disp-gamma",.data = &mt8173_gamma_driver_data}, {},}; MODULE_DEVICE_TABLE(of, mtk_disp_gamma_driver_dt_match); -- 2.30.0.365.g02bc693789-goog
Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek