Re: [Nouveau] [PATCH v4 00/17] drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers

On Sat, 24 Apr 2021 at 04:43, Lyude Paul lyude@redhat.com wrote:

Since it's been asked quite a few times on some of the various DP related patch series I've submitted to use the new DRM printk helpers, and it technically wasn't really trivial to do this before due to the lack of a consistent way to find a drm_device for an AUX channel, this patch series aims to address this. In this series we:

• (NEW! starting from V3) Make sure drm_dbg_*() and friends can handle NULL drm device pointers
• Clean-up potentially erroneous usages of drm_dp_aux_init() and drm_dp_aux_register() so that actual AUX registration doesn't happen until we have an associated DRM device
• Clean-up any obvious errors in drivers we find along the way
• Add a backpointer to the respective drm_device for an AUX channel in drm_dp_aux.drm_dev, and hook it up in every driver with an AUX channel across the tree
• Add a new ratelimited print helper we'll need for converting the DP helpers over to using the new DRM printk helpers
• Fix any inconsistencies with logging in drm_dp_helper.c so we always have the aux channel name printed
• Prepare the various DP helpers so they can find the correct drm_device to use for logging
• And finally, convert all of the DP helpers over to using drm_dbg_*() and drm_err().

Major changes in v4:

• Don't move i2c aux init into drm_dp_aux_init(), since I think I've found a much better solution to tegra's issues: https://patchwork.freedesktop.org/series/89420/

I've given this a general once over, seems like a good plan and since it's mostly mechanical.

for the series: Reviewed-by: Dave Airlie airlied@redhat.com

Dave.