Re: [PATCH 09/12] ttm: Provide DMA aware TTM page pool code.

....

On 11/08/2011 12:40 AM, j.glisse@gmail.com wrote:

diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h index ae06e42..beef9ab 100644 --- a/include/drm/ttm/ttm_bo_driver.h +++ b/include/drm/ttm/ttm_bo_driver.h @@ -104,6 +104,7 @@ enum ttm_caching_state {

• @caching_state: The current caching state of the pages.
• @state: The current binding state of the pages.
• @dma_address: The DMA (bus) addresses of the pages (if TTM_PAGE_FLAG_DMA32)

• • @alloc_list: used by some page allocation backend

As mentioned in the comment to patch 7, could we put this in a struct ttm_dma_tt, which embeds struct ttm_tt?

• This is a structure holding the pages, caching- and aperture binding
• status for a buffer object that isn't backed by fixed (VRAM / AGP)

@@ -127,6 +128,7 @@ struct ttm_tt { tt_unpopulated, } state; dma_addr_t *dma_address;

• struct list_head alloc_list; };