Hi Prashant,
I love your patch! Yet something to improve:
[auto build test ERROR on drm/drm-next] [also build test ERROR on usb/usb-testing v5.19-rc1 next-20220608] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Prashant-Malani/usb-typec-Int... base: git://anongit.freedesktop.org/drm/drm drm-next config: nios2-buildonly-randconfig-r006-20220608 (https://download.01.org/0day-ci/archive/20220609/202206090626.D0er2ez1-lkp@i...) compiler: nios2-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/2ac4609c73d7bb4d1a585dae845599... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Prashant-Malani/usb-typec-Introduce-typec-switch-binding/20220608-042545 git checkout 2ac4609c73d7bb4d1a585dae84559967ced3bad6 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=nios2 SHELL=/bin/bash drivers/gpu/drm/bridge/analogix/
If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot lkp@intel.com
All error/warnings (new ones prefixed by >>):
In file included from drivers/gpu/drm/bridge/analogix/anx7625.c:18:
include/linux/usb/typec_mux.h:83:19: warning: no previous prototype for 'fwnode_typec_mux_get' [-Wmissing-prototypes]
83 | struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode, | ^~~~~~~~~~~~~~~~~~~~
include/linux/usb/typec_mux.h:89:6: warning: no previous prototype for 'typec_mux_put' [-Wmissing-prototypes]
89 | void typec_mux_put(struct typec_mux *mux) {} | ^~~~~~~~~~~~~
include/linux/usb/typec_mux.h:91:5: warning: no previous prototype for 'typec_mux_set' [-Wmissing-prototypes]
91 | int typec_mux_set(struct typec_mux *mux, struct typec_mux_state *state) | ^~~~~~~~~~~~~
include/linux/usb/typec_mux.h:103:1: warning: no previous prototype for 'typec_mux_register' [-Wmissing-prototypes]
103 | typec_mux_register(struct device *parent, const struct typec_mux_desc *desc) | ^~~~~~~~~~~~~~~~~~
include/linux/usb/typec_mux.h:107:6: warning: no previous prototype for 'typec_mux_unregister' [-Wmissing-prototypes]
107 | void typec_mux_unregister(struct typec_mux *mux) {} | ^~~~~~~~~~~~~~~~~~~~
include/linux/usb/typec_mux.h:109:6: warning: no previous prototype for 'typec_mux_set_drvdata' [-Wmissing-prototypes]
109 | void typec_mux_set_drvdata(struct typec_mux *mux, void *data) {} | ^~~~~~~~~~~~~~~~~~~~~
include/linux/usb/typec_mux.h:110:7: warning: no previous prototype for 'typec_mux_get_drvdata' [-Wmissing-prototypes]
110 | void *typec_mux_get_drvdata(struct typec_mux *mux) | ^~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/bridge/analogix/anx7625.c: In function 'anx7625_register_mode_switch':
drivers/gpu/drm/bridge/analogix/anx7625.c:2617:30: error: assignment to 'struct typec_mux_dev *' from incompatible pointer type 'struct typec_mux *' [-Werror=incompatible-pointer-types]
2617 | port_data->typec_mux = typec_mux_register(dev, &mux_desc); | ^ drivers/gpu/drm/bridge/analogix/anx7625.c: In function 'anx7625_unregister_typec_switches':
drivers/gpu/drm/bridge/analogix/anx7625.c:2631:57: error: passing argument 1 of 'typec_mux_unregister' from incompatible pointer type [-Werror=incompatible-pointer-types]
2631 | typec_mux_unregister(ctx->typec_ports[i].typec_mux); | ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ | | | struct typec_mux_dev * In file included from drivers/gpu/drm/bridge/analogix/anx7625.c:18: include/linux/usb/typec_mux.h:107:45: note: expected 'struct typec_mux *' but argument is of type 'struct typec_mux_dev *' 107 | void typec_mux_unregister(struct typec_mux *mux) {} | ~~~~~~~~~~~~~~~~~~^~~ cc1: some warnings being treated as errors
vim +2617 drivers/gpu/drm/bridge/analogix/anx7625.c
2590 2591 static int anx7625_register_mode_switch(struct device *dev, struct device_node *node, 2592 struct anx7625_data *ctx) 2593 { 2594 struct anx7625_port_data *port_data; 2595 struct typec_mux_desc mux_desc = {}; 2596 char name[32]; 2597 u32 port_num; 2598 int ret; 2599 2600 ret = of_property_read_u32(node, "reg", &port_num); 2601 if (ret) 2602 return ret; 2603 2604 if (port_num >= ctx->num_typec_switches) { 2605 dev_err(dev, "Invalid port number specified: %d\n", port_num); 2606 return -EINVAL; 2607 } 2608 2609 port_data = &ctx->typec_ports[port_num]; 2610 port_data->ctx = ctx; 2611 mux_desc.fwnode = &node->fwnode; 2612 mux_desc.drvdata = port_data; 2613 snprintf(name, sizeof(name), "%s-%u", node->name, port_num); 2614 mux_desc.name = name; 2615 mux_desc.set = anx7625_typec_mux_set; 2616
2617 port_data->typec_mux = typec_mux_register(dev, &mux_desc);
2618 if (IS_ERR(port_data->typec_mux)) { 2619 ret = PTR_ERR(port_data->typec_mux); 2620 dev_err(dev, "Mode switch register for port %d failed: %d", port_num, ret); 2621 } 2622 2623 return ret; 2624 } 2625 2626 static void anx7625_unregister_typec_switches(struct anx7625_data *ctx) 2627 { 2628 int i; 2629 2630 for (i = 0; i < ctx->num_typec_switches; i++)
2631 typec_mux_unregister(ctx->typec_ports[i].typec_mux);
2632 } 2633