On Thu, 24 Jun 2021, Uwe Kleine-König wrote:
Hi Lee,
On Tue, Jun 22, 2021 at 02:12:57PM +0100, Lee Jones wrote:
On Mon, 21 Jun 2021, Uwe Kleine-König wrote:
The practical upside here is that this only needs a single API call to program the hardware which (depending on the underlaying hardware) can be more effective and prevents glitches.
Up to now the return value of the pwm functions was ignored. Fix this and propagate the error to the caller.
Signed-off-by: Uwe Kleine-König u.kleine-koenig@pengutronix.de
drivers/video/backlight/lm3630a_bl.c | 42 +++++++++++++--------------- 1 file changed, 19 insertions(+), 23 deletions(-)
Fixed the subject line and applied, thanks.
It's not obvious to me what needed fixing here, and I don't find where you the patches, neither in next nor in https://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git; so I cannot check what you actually changed.
I assume you did s/lm3630a/lm3630a_bl/ ? I didn't because it felt tautological.
No, but perhaps I should have. Format goes:
<backlight>: <driver_file_name>: <Subject starting with uppercase>
Where <driver_file_name> has the file extension removed.