Re: [PATCH 39/40] drm/amd/pm/powerplay/smumgr/fiji_smumgr: Remove unused variable 'result'

On Tue, Nov 24, 2020 at 2:45 PM Lee Jones lee.jones@linaro.org wrote:

Fixes the following W=1 kernel build warning(s):

drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/fiji_smumgr.c: In function ‘fiji_populate_smc_boot_level’: drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/fiji_smumgr.c:1603:6: warning: variable ‘result’ set but not used [-Wunused-but-set-variable]

Cc: Evan Quan evan.quan@amd.com Cc: Alex Deucher alexander.deucher@amd.com Cc: "Christian König" christian.koenig@amd.com Cc: David Airlie airlied@linux.ie Cc: Daniel Vetter daniel@ffwll.ch Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones lee.jones@linaro.org

Applied. Thanks!

Alex

---

.../gpu/drm/amd/pm/powerplay/smumgr/fiji_smumgr.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/fiji_smumgr.c b/drivers/gpu/drm/amd/pm/powerplay/smumgr/fiji_smumgr.c index fef9d3906fccd..fea008cc1f254 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/smumgr/fiji_smumgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/smumgr/fiji_smumgr.c @@ -1600,20 +1600,19 @@ static int fiji_populate_smc_uvd_level(struct pp_hwmgr *hwmgr, static int fiji_populate_smc_boot_level(struct pp_hwmgr *hwmgr, struct SMU73_Discrete_DpmTable *table) {

•   int result = 0;
    struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend);
  
    table->GraphicsBootLevel = 0;
    table->MemoryBootLevel = 0;
  
    /* find boot level from dpm table */
  

•   result = phm_find_boot_level(&(data->dpm_table.sclk_table),
  

•                   data->vbios_boot_state.sclk_bootup_value,
  

•                   (uint32_t *)&(table->GraphicsBootLevel));
  

•   phm_find_boot_level(&(data->dpm_table.sclk_table),
  

•                       data->vbios_boot_state.sclk_bootup_value,
  

•                       (uint32_t *)&(table->GraphicsBootLevel));
  
  

•   result = phm_find_boot_level(&(data->dpm_table.mclk_table),
  

•                   data->vbios_boot_state.mclk_bootup_value,
  

•                   (uint32_t *)&(table->MemoryBootLevel));
  

•   phm_find_boot_level(&(data->dpm_table.mclk_table),
  

•                       data->vbios_boot_state.mclk_bootup_value,
  

•                       (uint32_t *)&(table->MemoryBootLevel));
  
    table->BootVddc  = data->vbios_boot_state.vddc_bootup_value *
                    VOLTAGE_SCALE;
  

-- 2.25.1

---

dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel