26 Jul
2020
26 Jul
'20
10:17 a.m.
On 7/26/20 9:15 AM, Sam Ravnborg wrote:
Hi Marek.
Hi,
On Sat, Jul 25, 2020 at 11:14:57PM +0200, Marek Vasut wrote:
Add very basic driver for Toshiba TC358762 DSI-to-DPI bridge, derived from tc358764 driver and panel-raspberrypi-touchscreen. This driver is meant to replace the panel-raspberrypi-touchscreen too, as the bridge connection can be described in DT too.
Signed-off-by: Marek Vasut marex@denx.de To: dri-devel@lists.freedesktop.org Cc: Eric Anholt eric@anholt.net Cc: Rob Herring robh+dt@kernel.org Cc: Sam Ravnborg sam@ravnborg.org Cc: devicetree@vger.kernel.org
Two general comments.
- This driver should use the bridge panel - this will simplify the driver in many places. We already have several good examples in-tree that does this.
Can you list such an example ?
- The driver does not respect the "flags" argument in the attach operation. All new bridge drivers shall respect the flags operation to prepare for use in a setup with chained bridges. In short the flags is used to determine if the display driver or the bridge creates the connector. When the bridge panel is introduced you can drop all the connector creation code and just pass the flag to the bridge panel. The bridge panel will then create the connector if requested. This is possible because this simple bridge driver does not add anything to the connector that the bridge panel does not know.
OK