On Fri, Oct 11, 2013 at 04:37:35PM -0600, Stephen Warren wrote:
On 10/07/2013 02:34 AM, Thierry Reding wrote:
This driver adds support to perform calibration of the MIPI pads for CSI and DSI.
diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c
+int tegra_mipi_calibrate(struct device *device)
...
- err = of_parse_phandle_with_args(device->of_node, "calibrate",
"#calibrate-cells", 0, &args);...
+static struct of_device_id tegra_mipi_of_match[] = {
- { .compatible = "nvidia,tegra114-mipi", },
Is the DT binding for that compatible value documented anywhere? I'm not sure what #calibrate-cells means; it doesn't seem to be used...
I forgot to add a binding document, but I've complemented my local patch series with one. The #calibrate-cells defines the number of cells used for the specifier and should be 1. I suspect that we'll never get to have more than 32 pads that can be calibrated, but perhaps at some point data other than a bitmask of the pads will be needed.
Thierry