Re: [PATCH] [RESEND] drm: fb_helper: fix CONFIG_FB dependency

On Wed, Oct 27, 2021 at 03:19:34PM +0200, Javier Martinez Canillas wrote:

On 10/27/21 14:18, Arnd Bergmann wrote:

[snip]

...

Right, how about this change on top?

--- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -117,9 +117,8 @@ config DRM_DEBUG_MODESET_LOCK

config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver"

•   depends on DRM
  

•   depends on FB=y || FB=DRM
  

•   select DRM_KMS_HELPER
  

•   depends on DRM_KMS_HELPER
  

•   depends on FB=y || FB=DRM_KMS_HELPER
    select FB_CFB_FILLRECT
    select FB_CFB_COPYAREA
    select FB_CFB_IMAGEBLIT
  
  

That would probably make it work for DRM=y, FB=m, DRM_KMS_HELPER=m, but it needs more randconfig testing, which I can help with.

Looks good to me as well.

Reviewed-by: Javier Martinez Canillas javierm@redhat.com

Is the mess I created sorted now, or something for me to do? I'm terribly burried in stuff :-/ -Daniel