On Fri, Feb 11, 2011 at 1:59 AM, Alex Deucher alexdeucher@gmail.com wrote:
On Thu, Feb 10, 2011 at 12:33 AM, Justin Mattock justinmattock@gmail.com wrote:
On Feb 9, 2011, at 2:09 PM, Alex Deucher wrote:
On Tue, Feb 8, 2011 at 4:20 PM, Alex Deucher alexdeucher@gmail.com wrote:
On Tue, Feb 8, 2011 at 3:52 PM, Justin P. Mattock justinmattock@gmail.com wrote:
With the current HEAD Im getting screen flickering really bad to point where it looks like the screen is damaged and/or half plugged-in etc..
the bisect pointed to here:
commit 619efb105924d8cafa0c1dd9389e9ab506f5425d
doing a git revert 619efb10592 gets the screen working properly again. I havent looked much through the code to see if I can fix this. for the time being I'll revert this on my machine with the current, until later on.
The attached patch should fix it assuming I got your pci ids correct. I'm done with the pll stuff; too may fixes break other boards. Just add a quirk table and be done with it.
The attached patch builds on the previous one and fixes an additional regression.
Alex
<0001-drm-radeon-kms-pll-quirk-cleanup.patch>
alright... didn't mean to keep you waiting(out of my office for most of the day).. Anyways patch applied, and everything looks good no screen jitters or flickering etc..
Reported-and-Tested-by: Justin P. Mattockjustinmattock@gmail.com
Thanks for sending this my way so my machine works..
Justin, can you try without these patches, but with the following patch instead?
Better yet, can you try the attached patch on top of 2.6.38-rc4 or newer?
Alex
diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c index cc6bdd8..2f9d113 100644 --- a/drivers/gpu/drm/radeon/atombios_crtc.c +++ b/drivers/gpu/drm/radeon/atombios_crtc.c @@ -562,7 +562,7 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc, } } /* this might work properly with the new pll algo */ -#if 0 /* doesn't work properly on some laptops */ +#if 1 /* doesn't work properly on some laptops */ /* use recommended ref_div for ss */ if (radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT)) { if (ss_enabled) {
cheers,
Justin P. Mattock