Re: [Intel-gfx] [PATCH 18/19] drm/i915/gtt: map the PD up front

On Mon, Apr 12, 2021 at 07:01:19PM +0300, Jani Nikula wrote:

On Mon, 12 Apr 2021, Daniel Vetter daniel@ffwll.ch wrote:

...

And that's some serious wtf. Yes we've done some compile-time type casting automagic between i915_priv and dev in the past, and I think even that was bad taste. But it was justified with that we have these everywhere (especially in the mmio macros), and it would be a terrible flag day.

FWIW, we had the dev_priv/dev macro trickery for a while to not have that flag day conversion, until everything used i915 or &i915->drm. But we got rid of it afterwards.

Yay, and yes that was the plan to avoid the flag day. And not as a great coding pattern that everyone should imitate ... -Daniel