Re: [PATCH v7 06/14] drm/mediatek: Add HDMI support

On Mon, 2015-11-30 at 22:07 +0100, Philipp Zabel wrote:

From: Jie Qiu jie.qiu@mediatek.com

This patch adds drivers for the HDMI bridge connected to the DPI0 display subsystem function block, for the HDMI DDC block, and for the HDMI PHY to support HDMI output.

Signed-off-by: Jie Qiu jie.qiu@mediatek.com Signed-off-by: Philipp Zabel p.zabel@pengutronix.de

---

<...>

+static int mtk_hdmi_setup_avi_infoframe(struct mtk_hdmi *hdmi,

• 			struct drm_display_mode *mode)
  

+{

• struct hdmi_avi_infoframe frame;
• u8 buffer[17];
• ssize_t err;
• err = drm_hdmi_avi_infoframe_from_display_mode(&frame, mode);
• if (err < 0) {

• dev_err(hdmi->dev,
  

• 	"Failed to get AVI infoframe from mode: %ld\n", err);
  

Please use %zd instead for ssize_t, otherwise you'll see warning message when compile this on 32bits platform.

Joe.C

• return err;
  

• }
• err = hdmi_avi_infoframe_pack(&frame, buffer, sizeof(buffer));
• if (err < 0) {

• dev_err(hdmi->dev, "Failed to pack AVI infoframe: %ld\n", err);
  

• return err;
  

• }
• mtk_hdmi_hw_send_info_frame(hdmi, buffer, sizeof(buffer));
• return 0;

+}