Re: [PATCH 02/18] drm/cma-helper: Fix locking in drm_fb_cma_debugfs_show

On Thu, Jul 09, 2015 at 11:32:34PM +0200, Daniel Vetter wrote:

This function takes two locks, both of them the wrong ones. This wasn't an oversight from my fb locking rework since both patches landed in parallel. We really only need fb_lock when walking that list, since everything we can reach from that is refcounted properly already.

Cc: Rob Clark robdclark@gmail.com Cc: Laurent Pinchart laurent.pinchart@ideasonboard.com Signed-off-by: Daniel Vetter daniel.vetter@intel.com

---

drivers/gpu/drm/drm_fb_cma_helper.c | 16 ++-------------- drivers/gpu/drm/drm_gem_cma_helper.c | 2 -- 2 files changed, 2 insertions(+), 16 deletions(-)

Reviewed-by: Thierry Reding treding@nvidia.com